Reviewed all commit messages.
Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ArielElp and @orizi)

corelib/src/starknet/secp256r1.cairo line 44 at r1 (raw file):

        } else {
            return secp256r1_get_point_from_x_syscall(x, true);
        }

Suggestion:

secp256_ec_new_syscall(x, y)

Reviewable status: 0 of 5 files reviewed, 2 unresolved discussions (waiting on @ilyalesokhin-starkware and @orizi)

corelib/src/starknet/secp256_trait.cairo line 83 at r1 (raw file):

renamed to is_valid_signature, now returns bool

corelib/src/starknet/secp256r1.cairo line 44 at r1 (raw file):

        } else {
            return secp256r1_get_point_from_x_syscall(x, true);
        }

Done.

Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status: all files reviewed, 3 unresolved discussions (waiting on @ArielElp and @orizi)

corelib/src/starknet/secp256k1.cairo line 82 at r2 (raw file):

) -> SyscallResult<(u256, u256)> implicits(GasBuiltin, System) nopanic;

/// Asserts that a Secp256 ECDSA signature is valid.

Fix the comment.

Code quote:

// Asserts that a Secp256 ECDSA signature is valid.

corelib/src/starknet/secp256k1.cairo line 92 at r2 (raw file):

}

/// Checks a Secp256 ECDSA signature.

fix

Code quote:

 Checks a Secp256 ECDSA signature.

corelib/src/starknet/secp256k1.cairo line 96 at r2 (raw file):

/// where N is the size of the curve.
/// Returns a Result with an error string if the signature is invalid.
fn is_eth_signature_valid(

consider moving the etherium related logic to eth.cairo.

Code quote:

is_eth_signature_valid

Reviewed 1 of 5 files at r2, 2 of 4 files at r3.
Reviewable status: 5 of 7 files reviewed, 3 unresolved discussions (waiting on @ilyalesokhin-starkware and @orizi)

corelib/src/starknet/secp256k1.cairo line 82 at r2 (raw file):

Done.

corelib/src/starknet/secp256k1.cairo line 92 at r2 (raw file):

Done.

corelib/src/starknet/secp256k1.cairo line 96 at r2 (raw file):

Moved to ethereum_signature.cairo (ideally we'd have eth.cairo with both address and signature but I don't want to move eth address as well, so IMO it's good enough)

Reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)